bshashikant commented on a change in pull request #1336:
URL: https://github.com/apache/hadoop-ozone/pull/1336#discussion_r477226741
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/common/ChunkBuffer.java
##########
@@ -44,9 +45,6 @@ static ChunkBuffer allocate(int capacity) {
* When increment <= 0, entire buffer is allocated in the beginning.
*/
static ChunkBuffer allocate(int capacity, int increment) {
- if (increment > 0 && increment < capacity) {
- return new IncrementalChunkBuffer(capacity, increment, false);
Review comment:
IncrementalChunkBuffer was added to address cases where ozone client
were running into OOM with keys less than chunk size , as without this, the
smallest buffer which will be allocated will always be equal to the chunk
size(4MB by default).
Please see https://issues.apache.org/jira/browse/HDDS-2331 for more details.
I would prefer to not remove this logic of incremental chunk buffer and may
be hide it within an internal config.
@elek , how much of perf gain we will have of we still do incremental buffer
allocation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
