bharatviswa504 commented on pull request #1404: URL: https://github.com/apache/hadoop-ozone/pull/1404#issuecomment-696243290
> > I see we used layOutVersion and tested the change. But this might cause failures to other test like when key and directory with same name, as we have not used new logic in KeyCreate request. (Some of these tests are added in master branch with [HDDS-4155](https://issues.apache.org/jira/browse/HDDS-4155). > > Let's add individual classes with UT's and once basic classes like Key Creation/and others are done then we can integrate it to OM. > > Sure, how about adding this UTs along with File/Key creation patch?. As we know, here its only the dir changes. As any way we are testing at UT, we can add these entries to KeyTable and implement these tests. (Similar to Old Requests) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
