ChenSammi commented on a change in pull request #1412: URL: https://github.com/apache/hadoop-ozone/pull/1412#discussion_r492517940
########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java ########## @@ -297,4 +300,17 @@ private BucketEncryptionInfoProto getBeinfo( CipherSuite.convert(metadata.getCipher()))); return bekb.build(); } + + public void checkQuotaBytesValid(OmVolumeArgs omVolumeArgs, + OmBucketInfo omBucketInfo) { + long volumeQuotaInBytes = omVolumeArgs.getQuotaInBytes(); + long quotaInBytes = omBucketInfo.getQuotaInBytes(); + if(volumeQuotaInBytes < quotaInBytes) { Review comment: Need check sum of all bucket quota under the Volume. Better cover this case in UT. We also need this check when update volume quato. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org