GlenGeng commented on a change in pull request #1371:
URL: https://github.com/apache/hadoop-ozone/pull/1371#discussion_r496533516
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocol/commands/CreatePipelineCommand.java
##########
@@ -39,6 +42,7 @@
private final ReplicationFactor factor;
private final ReplicationType type;
private final List<DatanodeDetails> nodelist;
+ private final List<Integer> priorityList;
Review comment:
I consider that, should move `RatisPipelineProvider.getPriorityList()`,
`HIGH_PRIORITY`, `LOW_PRIORITY` here, and replace priorityList in Ctor param as
suggestedLeader.
We can minimize the existence of `priorityList`, and the calculation logic
of priority in `RatisPipelineProvider` is a little bit weird.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
