amaliujia commented on pull request #1444:
URL: https://github.com/apache/hadoop-ozone/pull/1444#issuecomment-700874303


   @elek your suggestion make senses as the new util classes are dedicated to 
be used by `interface-storage`. If it is even dedicated to be used by a `codec` 
class, it can be moved into the `codec` class.
   
   How about let me try to remove util classes in the next PR? 
   
   This PR is to have a working migration for single proto migration to build 
consensus around naming convention, how to deal with helpers/util classes. As 
this PR looks good overall, I will move ~3 proto in each future PR to 
accelerate migrate process while keep each PR be easier to maintain. 
   
   I can address the util class comment in the next PR with more data points 
there (e.g. 3 more proto migration)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org

Reply via email to