adoroszlai opened a new pull request #1476:
URL: https://github.com/apache/hadoop-ozone/pull/1476


   ## What changes were proposed in this pull request?
   
   1. Make findbugs check correctly report compilation failure via exit code
   2. Compile test classes, required by `test-jar` dependency
   3. Exclude Protobuf generated classes in new 
`hadoop-ozone/interface-storage` module
   
   https://issues.apache.org/jira/browse/HDDS-4312
   
   ## How was this patch tested?
   
   1. Verified that findbugs check can [now 
fail](https://github.com/adoroszlai/hadoop-ozone/runs/1215266036#step:3:866) 
(without fixes 2 and 3)
   2. Verified that the check proceeds beyond compilation, and [finds actual 
findbugs 
violations](https://github.com/adoroszlai/hadoop-ozone/runs/1215409391#step:3:1808)
 (without fix 3)
   3. Verified that findbugs check 
[passes](https://github.com/adoroszlai/hadoop-ozone/runs/1215527172#step:3:1803)
 (with all 3 fixes)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org

Reply via email to