adoroszlai commented on a change in pull request #1478:
URL: https://github.com/apache/hadoop-ozone/pull/1478#discussion_r500733595
##########
File path:
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/OzoneManagerServiceProviderImpl.java
##########
@@ -205,12 +205,12 @@ public void start() {
}
reconTaskController.start();
long initialDelay = configuration.getTimeDuration(
- RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY,
- RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY_DEFAULT,
+ OZONE_RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY,
+ OZONE_RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY_DEFAULT,
Review comment:
```suggestion
OZONE_RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY,
configuration.get(
ReconServerConfigKeys.RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY,
OZONE_RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY_DEFAULT),
```
##########
File path:
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconServerConfigKeys.java
##########
@@ -60,31 +60,31 @@
public static final String RECON_STORAGE_DIR = "recon";
- public static final String RECON_OM_SOCKET_TIMEOUT =
- "recon.om.socket.timeout";
- public static final String RECON_OM_SOCKET_TIMEOUT_DEFAULT = "5s";
+ public static final String OZONE_RECON_OM_SOCKET_TIMEOUT =
+ "ozone.recon.om.socket.timeout";
+ public static final String OZONE_RECON_OM_SOCKET_TIMEOUT_DEFAULT = "5s";
- public static final String RECON_OM_CONNECTION_TIMEOUT =
- "recon.om.connection.timeout";
- public static final String RECON_OM_CONNECTION_TIMEOUT_DEFAULT = "5s";
+ public static final String OZONE_RECON_OM_CONNECTION_TIMEOUT =
+ "ozone.recon.om.connection.timeout";
+ public static final String OZONE_RECON_OM_CONNECTION_TIMEOUT_DEFAULT = "5s";
- public static final String RECON_OM_CONNECTION_REQUEST_TIMEOUT =
- "recon.om.connection.request.timeout";
+ public static final String OZONE_RECON_OM_CONNECTION_REQUEST_TIMEOUT =
+ "ozone.recon.om.connection.request.timeout";
- public static final String RECON_OM_CONNECTION_REQUEST_TIMEOUT_DEFAULT =
"5s";
+ public static final String OZONE_RECON_OM_CONNECTION_REQUEST_TIMEOUT_DEFAULT
= "5s";
- public static final String RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY =
- "recon.om.snapshot.task.initial.delay";
+ public static final String OZONE_RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY =
+ "ozone.recon.om.snapshot.task.initial.delay";
Review comment:
```suggestion
public static final String OZONE_RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY =
"ozone.recon.om.snapshot.task.initial.delay";
@Deprecated
public static final String RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY =
"recon.om.snapshot.task.initial.delay";
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
