prashantpogde commented on a change in pull request #1486:
URL: https://github.com/apache/hadoop-ozone/pull/1486#discussion_r502986176
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##########
@@ -400,6 +405,66 @@ public void processNodeReport(DatanodeDetails
datanodeDetails,
}
}
+ /**
+ * Process Layout Version report.
+ *
+ * @param datanodeDetails
+ * @param layoutVersionReport
+ */
+ @Override
+ public void processLayoutVersionReport(DatanodeDetails datanodeDetails,
+ LayoutVersionProto layoutVersionReport) {
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Processing Layout Version report from [datanode={}]",
+ datanodeDetails.getHostName());
+ }
+ if (LOG.isTraceEnabled()) {
+ LOG.trace("HB is received from [datanode={}]: <json>{}</json>",
+ datanodeDetails.getHostName(),
+ layoutVersionReport.toString().replaceAll("\n", "\\\\n"));
+ }
+
+ if (layoutVersionReport != null) {
+ int scmSlv = scmLayoutVersionManager.getSoftwareLayoutVersion();
+ int scmMlv = scmLayoutVersionManager.getMetadataLayoutVersion();
+ OzoneUpgradeState scmUpgradeState =
+ scmLayoutVersionManager.getUpgradeState();
+ int dnSlv = layoutVersionReport.getSoftwareLayoutVersion();
+ int dnMlv = layoutVersionReport.getMetadataLayoutVersion();
+
+ // If the data node slv is > scm slv => log error condition
+ if (dnSlv > scmSlv) {
+ LOG.error("Rogue data node {} in the cluster. " +
+ "DataNode SoftwareLayoutVersion = {}, SCM " +
+ "SoftwareLayoutVersion = {}",
+ datanodeDetails.getHostName(), dnSlv, scmSlv);
+ }
+
+ // If the datanode slv < scm slv, it can not be allowed to be part of
+ // any pipeline. However it can be allowed to join the cluster
+ if (dnMlv < scmMlv) {
+ LOG.warn("Data node {} can not be used in any pipeline in the " +
+ "cluster. " + "DataNode MetadataLayoutVersion = {}, SCM " +
+ "MetadataLayoutVersion = {}",
+ datanodeDetails.getHostName(), dnMlv, scmMlv);
+
+ // TBD: Add NEED_UPGRADE state and fill out state transitions
+ // around this state. Fire event to move this data node to
+ // NEED_UPGRADE state. The DataNode will be considered HEALTHY in
+ // this state but it can not be made part of any Pipeline.
+
+ // Also send Finalize command to the data node. Its OK to
+ // send Finalize command multiple times.
+ scmNodeEventPublisher.fireEvent(SCMEvents.DATANODE_COMMAND,
+ new CommandForDatanode<>(datanodeDetails.getUuid(),
+ new FinalizeNewLayoutVersionCommand(true,
+ LayoutVersionProto.newBuilder()
+ .setSoftwareLayoutVersion(dnSlv)
+ .setMetadataLayoutVersion(dnSlv).build())));
Review comment:
yes, its asking datanode to move to dnSlv because thats the software
version datanode is running. Its possible that its lower than the SCM slv but
dnSlv is the correct version for that particular datanode,.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
