GlenGeng commented on a change in pull request #1228: URL: https://github.com/apache/hadoop-ozone/pull/1228#discussion_r504374249
########## File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java ########## @@ -562,13 +562,18 @@ private Response createMultipartKey(String bucket, String key, long length, OmMultipartCommitUploadPartInfo omMultipartCommitUploadPartInfo = ozoneOutputStream.getCommitUploadPartInfo(); - String eTag = omMultipartCommitUploadPartInfo.getPartName(); + if (omMultipartCommitUploadPartInfo != null) { Review comment: Hi @maobaolong, could you please add a new patch, just revert the change and replace ``` } finally { IOUtils.closeQuietly(ozoneOutputStream); } ``` with ``` } finally { if (ozoneOutputStream != null) { ozoneOutputStream.close(); } } ``` ? Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org