Hi Xia,
I watched your patch. Probably, I think that this patch has a problem
with the following check. Do you need if "rv" is equal to 0? The lseek
man describes that the lseek return -1 if the lseek error happens.
Otherwise, lseek return the number of bytes. So, 0 may not be error.
And, this patch includes several "rv <= 0". What do you think about
it?
+ rv = lseek(fd, 0, SEEK_SET);
+ if (rv <= 0) {
+ log_error("lseek set offset to 0 error: %d: %s",
+ fd, strerror(errno));
+ }
Sincerely,
Yuichi
2013/2/1 Yuichi SEINO <seino.clust...@gmail.com>:
> Hi Xia,
>
> Thanks for the patch. I have a question.
>
> Following errors always be output. Are you correct about the log level?
> If this isn't a error, it would be better to output as a log info.
> And, I attached the log.
>
> ERROR: lseek set offset to 0 error: 4: Success
> or
> ERROR: lseek set offset to 0 error: 4: Operation now in progress
>
> Sincerely,
> Yuichi
>
--
Yuichi SEINO
METROSYSTEMS CORPORATION
E-mail:seino.clust...@gmail.com
_______________________________________________
Pacemaker mailing list: Pacemaker@oss.clusterlabs.org
http://oss.clusterlabs.org/mailman/listinfo/pacemaker
Project Home: http://www.clusterlabs.org
Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
Bugs: http://bugs.clusterlabs.org
