Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461119

Thomas Spura <toms...@fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #8 from Thomas Spura <toms...@fedoraproject.org> 2010-01-26 
18:22:30 EST ---
(In reply to comment #7)
> Thx for the review, and sorry for the late answear.    

Indeed, pretty bad. Need to to the review from scratch ;)

Addings to the review in comment 6:

- permissions ok
- examples noarch ok
- license is ok


###################################

One thing left:
Please use:
%files doc
%defattr(-,root,root,-)
%doc examples __doc/html

and not
%doc examples __doc/*

This will leave out AUTHORS ChangeLog... which are already in the main package.
(No need to include them twice in two different packages.)


###################################

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to