Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507491

--- Comment #9 from Bernard Johnson <bjohn...@symetrix.com> 2010-01-31 15:47:32 
EST ---
> Provides should have version, use macro e.g %{version}

Fixed

> Use macro %{__fixperms} instead of chown in build section.

Unless I misunderstood you, %{_fixperms} won't work because it uses a+X. 
Instead I ran a find for all file and changed the mode.  rpmlint no longer
complains.

> Also I dislike your exclude in section files.

I actually find it much more straight forward then deleting files after
install.  Also, it is part of the template created by 'rpmdev-newspec -t perl'
:)

Spec URL: http://fedorapeople.org/~bjohnson/perl-forks.spec
SRPM URL: http://fedorapeople.org/~bjohnson/perl-forks-0.33-3.fc12.src.rpm

* Sun Jan 31 2010 Bernard Johnson <bjohn...@symetrix.com> - 0.33-3
- fix permissions in build to squelch rpmlint complaints
- add version to provides

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to