Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=560179 --- Comment #3 from Christoph Wickert <cwick...@fedoraproject.org> 2010-01-31 17:26:34 EST --- (In reply to comment #2) > > - The package doesn't build against the Polkit in F12, so please add the > > minimim required version to the polkit-devel BuildRequires. > > Hmm, I just tried, and it build fine in mock here. What failure are you seeing > ? http://koji.fedoraproject.org/koji/taskinfo?taskID=1955235 > > - The Exec= line in the desktop file should not have an absolute path. > > Not sure there is any rule about this, and I don't think it makes a difference > either way. But I've remove the path in git, will be in the next release. Fine with me. > > - Add INSTALL='install -p' to make install to preserve the timestamps of the > > data files (pixmaps etc). > > I don't think it makes any difference whatsoever, but I'll add it to make you > happy. It's not to make me happy but to follow the guidelines: https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps > > - There are files from fprint and GDM included in the source, which violates > > the "No duplication of system libraries" policy. I assume this code will be > > moved into it's proper upstream packages once it's mature and you will build > > against these packages then, so for now this is not a problem. > > Not sure where you are going with this, but copying and adapting sources from > elsewhere is quite normal, and the system library rule doesn't even come into > play since we are not building any libraries here at all. Please take a look at the bugs blocking the duplication of system libraries tracker bug 504493, for example at but 495310. Duplication of system libraries not only means that you must not build new, modified libs but also that you should not contain forked copies of other code in your tarballs to build against them. The focus should be on upstreaming the changes and I'm sure you will be going the right thing here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
