Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=559699 --- Comment #5 from Fabio Massimo Di Nitto <fdini...@redhat.com> 2010-02-09 03:54:46 EST --- Hi Nuno, we are getting very close but there are still some issues in the packaging. I have compared the new spec file vs both fedora rawhide and fedora12. It appears you have dropped a major patch from the new rpm (so_number.patch) and that also shows in the file list in the spec file (for eg.): -%_libdir/libqmfconsole.so.3 -%_libdir/libqmfconsole.so.3.0.0 +%_libdir/libqmfconsole.so.2 +%_libdir/libqmfconsole.so.2.0.0 This creates a set of packages that are not really usable: [r...@fedora12-node2 ~]# rpm -U *.rpm error: Failed dependencies: libqmfconsole.so.3()(64bit) is needed by (installed) fence-virtd-qpid-0.1.3-1.fc12.x86_64 libqpidcommon.so.3()(64bit) is needed by (installed) rhm-cpp-server-store-0.5.829175-3.fc12.x86_64 libqpidbroker.so.3()(64bit) is needed by (installed) rhm-cpp-server-store-0.5.829175-3.fc12.x86_64 So here is what I´d like to see: 1) get rawhide to have a version > than F-12 > F-11. this is a fundamental prerequisite for updates. So we also have one single reference point to compare. 2) fix the new spec file so that has a version > than rawhide 3) check again that the new packages can update from the old one if rawhide needs extra patches to build, that is absolutely fine (and somewhat irrelevant for the review). nice to see define -> global change run an rpmlint over the newly generated srpm/rpm. There are few errors/warnings that are relevant to those changes: qmf.x86_64: W: invalid-license ASL 2.0, LGPL 2.0 qpid-cpp.src:66: W: unversioned-explicit-obsoletes qpidc (a bunch of those) qpid-cpp-client.x86_64: W: self-obsoletion qpidc obsoletes qpidc qpid-cpp-client.x86_64: E: library-without-ldconfig-postin /usr/lib64/libqpidclient.so.2.0.0 ruby-qmf.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ruby/site_ruby/1.8/x86_64-linux/qmfengine.so ['/builddir/build/BUILD/qpidc-0.5.829175/cpp/src/.libs'] most of the warnings/errors are very easy to fix. Fabio -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
