Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562585 --- Comment #6 from Thomas Spura <toms...@fedoraproject.org> 2010-02-16 06:25:25 EST --- Some other comments, I just noticed ;) - better use 'make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"' This way the timestamps are preserved, when installing. - rpmlint is not clean: ccd2iso.src:51: W: macro-in-%changelog %{version} Use %%{version} in the changelog, so this will not be considered as a macro. This can be done, when a sponsor wants to sponsor you. I think, you should wait for one and do some other informal reviews of other packages. See: http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored#Reviewing_Packages SPEC URL: http://tomspur.fedorapeople.org/other_review/ccd2iso.spec SRPM URL: http://tomspur.fedorapeople.org/other_review/ccd2iso-0.3-2.fc12.src.rpm (Sponsor FYI: I get the source from the src.rpm he sended via mail and not via spectool -g, so 'sources matches upstream' still needs to be verified.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
