Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=545408

Thomas Spura <toms...@fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #6 from Thomas Spura <toms...@fedoraproject.org> 2010-02-16 
06:41:42 EST ---
(In reply to comment #4)
> - Please bump the release, when making changes the next time, so changes are
> also visible.    

Still not bumped :'(

- %files ok now
- debuginfo ok

SHOULD:
- Please delete ${RPM_BUILD_DIR}/${RPM_PACKAGE_NAME}-${RPM_PACKAGE_VERSION}/
everywhere, because this is not needed.
  Or is there any reason, you use that, that I don't see atm?

- Moving resources/icons/COPYING around should be done in %prep



#################################

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to