Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562467 Xavier Bachelot <xav...@bachelot.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |huzai...@redhat.com, | |xav...@bachelot.org --- Comment #2 from Xavier Bachelot <xav...@bachelot.org> 2010-02-18 18:43:07 EST --- The spec file looks generally clean, with a few nitpicks : - the -b 0 argument to %setup is useless. - Why no parallel build ? ("make" rather than "make %{?_smp_mflags}"). If it's failing then that should be added as a comment into the spec. - the .gz at the end of the manfiles lines in %file should be changed to .* in case the compression format ever change. Actually, my biggest concern about this review request is it should not be a review request in the first place as openvas-libraries is already packaged. I suggest you submit a patch against the devel branch to Huzaifa, and also that you apply for co-maintainership on openvas-libraries. I'm adding him to the CC list. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
