Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=554714

Thomas Spura <toms...@fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #10 from Thomas Spura <toms...@fedoraproject.org> 2010-02-20 
08:15:45 EST ---
Review:

GOOD:
- builds in koji:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=2001215
- readable
- macros everywhere
- %files ok
- permissions ok
- %clean there
- license ok
  (no headers, but contains LICENCE file)
- buildarch noarch ok
- no libs
- no .pc
- no .la
- rpmlint:
$ rpmlint python-psutil-0.1.2-3.fc12.src.rpm
noarch/python3-psutil-0.1.2-3.fc12.noarch.rpm
noarch/python-psutil-0.1.2-3.fc12.noarch.rpm 
python-psutil.src: W: spelling-error %description -l en_US functionalities ->
functionality, functionalists, functionalism
python-psutil.src: W: spelling-error %description -l en_US ps -> PS, pa, pd
python-psutil.src: W: invalid-url URL: http://psutil.googlecode.com/
IncompleteRead(0 bytes read)
python-psutil.src: W: invalid-url Source0:
http://psutil.googlecode.com/files/psutil-0.1.2.tar.gz HTTP Error 404: Not
Found
python3-psutil.noarch: W: spelling-error %description -l en_US functionalities
-> functionality, functionalists, functionalism
python3-psutil.noarch: W: spelling-error %description -l en_US ps -> PS, pa, pd
python3-psutil.noarch: W: invalid-url URL: http://psutil.googlecode.com/
IncompleteRead(0 bytes read)
[...]
python-psutil.noarch: W: spelling-error %description -l en_US functionalities
-> functionality, functionalists, functionalism
python-psutil.noarch: W: spelling-error %description -l en_US ps -> PS, pa, pd
python-psutil.noarch: W: invalid-url URL: http://psutil.googlecode.com/
IncompleteRead(0 bytes read)

invalid-urls are false positive, spelling is correct

-> ok

The requires of python(abi) = 3.1 is now there, I just needed to update to fc13
redhat-rpm-config.


SHOULD:
- Please BR python2-tools and not python-tools, to be consistend with BR
python2-devel.


###########################

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to