Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225700

--- Comment #3 from Kamil Dudka <kdu...@redhat.com> 2010-02-23 08:37:30 EST ---
considered OK
=============
- almost silent rpmlint with the the patch applied:

docbook-dtds.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 299, tab: line
269)
docbook-dtds.noarch: W: dangerous-command-in-%post chmod
docbook-dtds.noarch: W: dangerous-command-in-%postun rm

- sane summary/description
- valid project URL and source URL
- upstream zip archives are match the ones from look-aside cache
- dist tag OK
- license tag OK
- %prep OK
- %clean OK
- %defattr OK
- %files OK
- %doc OK, the hack with cp --parents is IMO a bit subtle, but it works


may be better
=============
- BuildRoot tag should be %(mktemp -ud
%{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)

- all explicit (Build)Requires may be eliminated (far beyond Fedora 11)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to