Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568053 Terje Røsten <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|[email protected] |[email protected] Flag| |fedora-review? --- Comment #6 from Terje Røsten <[email protected]> 2010-02-25 13:53:01 EST --- ok rpmlint ok naming ok spec - license, looks like GPLv2+ to me, why are you using LGPLv2? ok lang ok sha1sum bb0bddb3a9de6f6ceeee7e296b5315b8b7e59ea5 4ti2-1.3.2.tar.gz bb0bddb3a9de6f6ceeee7e296b5315b8b7e59ea5 4ti2-1.3.2.tar.gz.1 62d93d38f7f95c8fb6711ca5c33597815f55cf45 4ti2_manual.pdf 62d93d38f7f95c8fb6711ca5c33597815f55cf45 4ti2_manual.pdf.1 ok dirs ok perms pedantic stuff: - empty lines in %build and %install Over all with changed license this should be ok. However, there a serious issue about the generic names: /usr/bin/circuits /usr/bin/genmodel /usr/bin/gensymm /usr/bin/graver /usr/bin/groebner /usr/bin/hilbert /usr/bin/markov /usr/bin/minimize /usr/bin/normalform /usr/bin/qsolve /usr/bin/rays /usr/bin/walk Can prefix all with 4ti2, but then the documentation would be wrong. (See the environment-modules package) Or maybe it makes sense to use the modules systems to manage this? $ module load 4ti2 (See the environment-modules package) Would bring in all the names, but only for the user wanting this. Is there any policy on modules usage? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
