Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=573012 Tom "spot" Callaway <tcall...@redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tcall...@redhat.com --- Comment #1 from Tom "spot" Callaway <tcall...@redhat.com> 2010-03-12 10:49:19 EST --- They're really not false alarms. I have no idea why those binaries end up in /usr/lib/desktopcouch. They need to be in %{_bindir}. My spec had this line at the end of %install: # Really? You put them there? In /usr/lib (note, not %{_libdir})? Fail. mv %{buildroot}/usr/lib/desktopcouch/desktopcouch-* %{buildroot}%{_bindir} A few other points: * The desktopcouch package should own %dir %{_sysconfdir}/xdg/desktop-couch/ * The descriptions need to be relevant and specific for the subpackages, even if they simply repeat their Summary. * You do not need to copy the licenses and docs for all of the packages where there is a forced dependency chain. This means that only desktopcouch needs them not the others. * Dependencies on subpackages should be on desktopcouch = %{version}-%{release}, not just %{version}. Nevertheless, a good start. Fix those issues and I'll finish out the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
