Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=573264 Rex Dieter <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Rex Dieter <[email protected]> 2010-03-13 15:39:08 EST --- 1. avoiding Conflicts Since this is targeted for qt-4.7.0 anyway, we can possibly skip the Conflicts, and do something like this instead: BuildRequires: qt4-devel >= 4.7.0 Requires qt4%{?_isa} >= %{_qt4_version} I won't consider this a review blocker, but let's do our best to resolve the issue prior to releasing any builds. Naming: ok scriplets: ok licensing: ok macros: ok no .desktop file: documented justification for exception, ok. Otherwise, fairly simple and clean. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
