Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=567257 --- Comment #9 from Mamoru Tasaka <mtas...@ioa.s.u-tokyo.ac.jp> 2010-03-20 13:15:09 EDT --- For 0.1.9-1: ! gtk2 version specific dependency >> * BR/Requires >> - ">= 2.16.0" on "BR: gtk2-devel" is not needed because gtk2-devel >> in currently supported Fedora branches all satisfy this dependency: >> https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires > The explicit requires guideline doesn't apply here as I'm not requiring a > library. Only the version number could be omitted, if all currently supported > Fedora branches fulfilled this requirement, but EPEL does not. - So I am talking about "if all currently supported...." item, and are you really considering EPEL? ( menu-cache does not even exist on EL-5 so I don't think you really care for EPEL. Also I am against that we should consider EPEL version dependency "by default" ) ! duplicate description > Why not? Only the first part of the description is the same, the rest is > different for the (sub)packages. IMO the description must be understandable > for > every single package standalone because nether a package manager nor rpm -i > will show you the description of the required packages. - But you don't repeat the description written in "main" package on the rest -devel packages (and I think the description should not be repeated). I don't see any reason why you want to repeat the description on -gtk package when -gtk package depends on main package. ... Anyway the above 2 are not blockers. * Directory ownership issue - Still the following directories are not owned by any packages --------------------------------------------------------------- %{_libdir}/libfm/ (check -gtk subpackage) --------------------------------------------------------------- * Desktop file https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage - Installed desktop file must be handled by desktop-file-{install,validate} ? By the way do you intend to install libfm only for F-13+ (as F-12 menu-cache does not satisfy the dependency)? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
