Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=561470 --- Comment #13 from Petr Muller <pmul...@redhat.com> 2010-03-22 13:11:38 EDT --- (In reply to comment #12) > > Spec URL: http://www.afri.cz/files/beakerlib.spec > > SRPM URL: http://www.afri.cz/files/beakerlib-1.0-2.src.rpm > The src.rpm URL does not work, I've instead used > http://afri.fedorapeople.org/beakerlib/beakerlib-1.0-2.fc12.src.rpm Sorry for that, I b0rked the filename. New ones: http://www.afri.cz/files/beakerlib-1.1-0.fc12.src.rpm http://www.afri.cz/files/beakerlib.spec > > [ FAIL ] MUST: rpmlint must be run on every package > beakerlib.src: W: invalid-url Source0: beakerlib-1.0.tar.gz > beakerlib.spec: W: invalid-url Source0: beakerlib-1.0.tar.gz > > I believe you mixed the definitions of URL and Source0. The > following > patch resolves the problem accordingly. Thanks for the patch - it should be fixed now. Source0: https://fedorahosted.org/released/%{name}/%{name}-%{version}.tar.gz URL: https://fedorahosted.org/%{name} $ rpmlint beakerlib-1.1-0.fc12.src.rpm beakerlib-1.1-0.fc12.noarch.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. > [ FAIL ] MUST: The License field in the package spec file must match the > actual license > > beakerlib.spec noted GPLv2, however the following files included in > beakerlib show 'GPLv2 or later': > git_rules.mk:1:# License: GPL v2 or later > py_rules.mk:1:# License: GPL v2 or later > rpmspec_rules.mk:1:# License: GPL v2 or later > upload_rules.mk:1:# License: GPL v2 or later > scm_rules.mk:1:# License: GPL v2 or later > > I think beakerlib.spec should note "GPLv2+" or the *.mk files should > be adjusted Fixed to GPLv2, one file was removed. > [ WARN ] MUST: The spec file for the package MUST be legible. > > It's common practice to include two newlines prior to each %section > in > the spec file. I'd recommend the same here for readability. Please > see the tool rpmdev-newspec (provided by rpmdevtools) or the spec > template included in vim now. Thanks, I didn't know that. I've added empty lines between sections. > [ FAIL ] MUST: The sources used to build the package must match the upstream > source, as provided in the spec URL. Reviewers should use md5sum for > this task. If no upstream URL can be specified for this package, > please see the Source URL Guidelines for how to deal with this. > > The Source0 line must be a URL to the location of the source > upstream. > Something like (note, the URL will depend on the location you post > this, but I'd recommend anchored somewhere from your fedorahosted > project space) ... I've moved the tarball to the fedorahosted release infrastructure, the tarballs will be here now: https://fedorahosted.org/released/beakerlib/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
