https://bugzilla.redhat.com/show_bug.cgi?id=820544
--- Comment #37 from Simone Caronni <negativ...@gmail.com> --- Hello, thanks for the comments. (In reply to comment #36) > * _isa in BuildRequires are insane. BuildRequires become the src.rpm's > Requires. And that's correct, as if I install a 64 bits package I expect to pull in 64 bit dependencies. Please read from comment #4 of this bug. > > Requires: freerdp-plugins < 1.1 > > Please add a comment to such explicit Requires. You can copy what you added > to the %changelog: > https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires It's explained in comment #1, I will add a note, then. > * The following lead to some head-scratching: > > > %post -p /sbin/ldconfig > > > > %postun -p /sbin/ldconfig Yes, this is probably a leftover, I will remove it. > > %files > ... > > %{_libdir}/guacamole/%{name}.so > > %{_libdir}/guacamole/%{name}.so.* > > So, some shared libs are stored in a private non-default path that is not in > default search path for shared libs. ldconfig is run nevertheless. This > prompted me to take a look at the libguac package. That one creates this > private directory and extends the run-time linker's search path list. > > Why? The libguac spec file doesn't answer the question. > > The libguac source code dlopen's these modules. They are named > "libguac-client-$(PROTOCOL).so". That's not a naming scheme that asks for > trouble. The libs could be stored in %_libdir without much risk of causing > file conflicts. > > A comment in the spec file that %{_libdir}/guacamole/ is provided by libguac > which is an automatic dependency would be nice, too. They were like you're saying before I was asked to do the opposite for libguac-client-vnc. Please see comment #8 of [1] for the explanation. Developers will add other plugins to this (Spice, SSH, etc,). [1] https://bugzilla.redhat.com/show_bug.cgi?id=820543 I will add a note for this as well, thanks. --Simone -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
