https://bugzilla.redhat.com/show_bug.cgi?id=832635

--- Comment #2 from Truong Anh Tuan <tua...@iwayvietnam.com> ---
(In reply to comment #1)
> just some quick comments:
> 
> - %defattr is no longer needed, it's the default
> - 'BuildRoot' is obsolete for recent Fedora versions.

Thanks. They would be removed.

> - The .desktop file is not handled correct,
> https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files

I have read these instructions more. Could you tell me more detailed what's
wrong with it?

> - http://evoluspencil.googlecode.com/files/pencil-2.0.tar.gz gives an 404
> error

Actually, the upstream developer did not release the whole software source as a
tar file like this. He sent me this SVN link:
http://evoluspencil.googlecode.com/svn/branches/pencil-2.0
I got sources, change some file/folder locations then build myself (of course,
I notified my changes to him)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to