https://bugzilla.redhat.com/show_bug.cgi?id=785491
Shawn Iwinski <shawn.iwin...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fed...@famillecollet.com,
| |shawn.iwin...@gmail.com
Whiteboard| |NotReady
--- Comment #1 from Shawn Iwinski <shawn.iwin...@gmail.com> ---
I am not an official package reviewer, but here are some comments I have for
this package:
*** It would help readability to group your Build* and Requires* statements
together instead of mixing them with each other and your Provides and Conflicts
statements
*** Your BuildRequires should be
BuildRequires: php-pear(PEAR) >= 1.7.0
instead of
BuildRequires: php-pear >= 1:1.4.9-1.2
(this would match what you have in bug 785606 and satisfy this package's
package.xml dependency)
*** Per package.xml requirements, please add:
Requires: php-common >= 5.2.0
*** phpci results: For completeness (and to prevent any future packaging issues
due to PHP package changes), you may wish to require the virtual packages
"php-reflection" and "php-spl".
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
