https://bugzilla.redhat.com/show_bug.cgi?id=785471

Remi Collet <fed...@famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?

--- Comment #3 from Remi Collet <fed...@famillecollet.com> ---
SHOULD:
Use %{pear_name} where possible
Consider adding %{pear_channel}

MUST:
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.

[!]: MUST Requires correct, justified where necessary.
BuildRequires and Requires same version of pear, according to package.xml
BuildRequires:  php-pear >= 1:1.7.0
Requires:  php-pear >= 1:1.7.0

Also add php-common >= 5.2.0 (waiting for a better provides in php)

[!]: MUST Package must own all directories that it creates.
Missing
%{pear_phpdir}/Horde
%{pear_phpdir}/Horde/Stream
%{pear_docdir}/Horde_Stream_Wrapper

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to