https://bugzilla.redhat.com/show_bug.cgi?id=839301

--- Comment #3 from Bohuslav "Slavek" Kabrda <bkab...@redhat.com> ---
- According to [1], the obsoletes shouldn't use macros, but rather hardcode the
version from where you renamed the package. E.g. you should have "Obsoletes:
django-evolution < 0.6.7-2".
- "%defattr(-,root,root,-)" is not needed in the %files section, unless you
want to build for EPEL 5 (which presumably you don't). Same applies for the
BuildRoot tag, %clean section and "rm -rf $RPM_BUILD_ROOT".
- You should delete the bundled egg-info directory in the %prep section (rm -rf
django_evolution.egg-info), so that it gets regenerated during %build.

These are not serious issues, so once you fix them, I will approve the package.

[1]
http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to