https://bugzilla.redhat.com/show_bug.cgi?id=839650
Michal Fojtik <mfoj...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mfoj...@redhat.com
--- Comment #1 from Michal Fojtik <mfoj...@redhat.com> ---
Review:
- The 'License: GPLv2+ or Ruby' seems to be wrong, according to GitHub page it
should be MIT
- Consider using %gem_name macro here:
URL: http://github.com/michaeldv/awesome_print
- Move the 'spec' files into -doc subpackage, since they are not needed for the
main gem funcionality.
%{gem_instdir}/spec/colors_spec.rb
....
- Consider removing these files:
%{gem_instdir}/.gitignore
%{gem_instdir}/.yardoc/checksums
%{gem_instdir}/.yardoc/objects/root.dat
%{gem_instdir}/.yardoc/proxy_types
%{gem_instdir}/Gemfile.lock
- Move LICENSE into main %files section
- Please run the 'spec' files in the %check section
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
