https://bugzilla.redhat.com/show_bug.cgi?id=840374

Parag AN(पराग) <panem...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #1 from Parag AN(पराग) <panem...@gmail.com> ---
Review:
+ koji scratch build
->http://koji.fedoraproject.org/koji/taskinfo?taskID=4242812

+ rpmlint on rpms gave
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ Source verified with upstream as (sha1sum)
4ed99a48f95abfccad7e60d04cdc47d36220fa3b  font-kalapi-0.1.tar.gz
4ed99a48f95abfccad7e60d04cdc47d36220fa3b  ../SOURCES/font-kalapi-0.1.tar.gz

+ License is OFL.

+ Follows packaging guidelines.

suggestions:
  1) I suggest to drop foundry name used as gujaratilexicon considering policy
The foundryname- prefix can optionally be skipped:
   * for entities that never released more than one font family

2) cp commands should preserve timestamp by using it as "cp -p"

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to