https://bugzilla.redhat.com/show_bug.cgi?id=842633

--- Comment #3 from Ankur Sinha (FranciscoD) <sanjay.an...@gmail.com> ---
(In reply to comment #2)
> - Probably just a typo: Your VR is 1.0.1-1, but you obsolete
> django-authopenid < 1.0.1-4. That should be 1.0.1-1, right?

Hey Bohuslav,

Not sure about this:

The django-authopenid package (that I'm renaming to python-django-authopenid)
had a current running package VR of 1.0.1-3. According to the example here[1],
the obsolete is correct:

python-django-authopeind-1.0.1-2 (latest spec) obsoletes django-authopenid <
1.0.1-4 (so, 1.0.1-{1,2,3})

The comment in the example says: "# Obsolete anything that is lower than the
_bumped release_ of the renamed package. Obsolete with hardcoded values of
renamed package"

Do have a look and let me know? I'll make the change if required, it's really a
tiny one. 

> - You should remove the egg-info directory in the %prep section, so that it
> gets recreated by python setup.py build.

Done. 

> 
> Otherwise the package looks good, so once you correct these nits, I will
> approve it.

New spec/srpm:

http://ankursinha.fedorapeople.org/python-django-authopenid/python-django-authopenid.spec

http://ankursinha.fedorapeople.org/python-django-authopenid/python-django-authopenid-1.0.1-2.fc17.src.rpm

* Wed Jul 25 2012 Ankur Sinha <ankursinha AT fedoraproject DOT org> 1.0.1-2
- Remove egg-info to ensure that setup.py builds it #842633

[1] https://fedoraproject.org/wiki/User:Bkabrda/Django_rename#django-bar

Thanks,
Ankur

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to