https://bugzilla.redhat.com/show_bug.cgi?id=845115
Matthias Runge <mru...@matthias-runge.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mru...@matthias-runge.de
--- Comment #1 from Matthias Runge <mru...@matthias-runge.de> ---
Some drive-by comments:
- you need an obsoletes:
- no need to clean up the build-root any more
- why did you remove the old changelog entries? They still belong to the
package
- defattrs not required
- you should enable the tests in a %check section
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
