https://bugzilla.redhat.com/show_bug.cgi?id=845136
--- Comment #1 from Matt Spaulding <mspauldin...@gmail.com> --- Package looks very good. See below for comments. RPM Lint Output: python26-tornado.spec:184: W: macro-in-%changelog %check python26-tornado.src: W: invalid-url URL: http://www.tornadoweb.org HTTP Error 405: Method Not Allowed python26-tornado.src:184: W: macro-in-%changelog %check python26-tornado.noarch: W: invalid-url URL: http://www.tornadoweb.org HTTP Error 405: Method Not Allowed python26-tornado-doc.noarch: W: invalid-url URL: http://www.tornadoweb.org HTTP Error 405: Method Not Allowed python26-tornado-doc.noarch: E: zero-length /usr/share/doc/python26-tornado-doc-2.2.1/demos/facebook/static/facebook.js 3 packages and 1 specfiles checked; 1 errors, 5 warnings. All warnings/errors look acceptable. I'm assuming even though the "facebook.js" file is zero-length that it is required for the demo code. Website does in fact exist. Key: x = good ! = bad - = n/a [x] License is acceptable (ASL 2.0) [x] License field in spec is correct [-] License files included in package %docs if included in source package [-] License files installed when any subpackage combination is installed [x] Spec written in American English [x] Spec is legible [x] Sources match upstream unless altered to fix permissibility issues Upstream MD5: ad8d943262bff57ef1b8f7b6d502ba04 Your MD5: ad8d943262bff57ef1b8f7b6d502ba04 [x] Build succeeds on at least one primary arch [x] Build succeeds on all primary arches or has ExcludeArch + bugs filed [x] BuildRequires correct, justified where necessary [-] Locales handled with %find_lang, not %_datadir/locale/* [-] %post, %postun call ldconfig if package contains shared .so files [x] No bundled libs [-] Relocatability is justified [x] Package owns all directories it creates [-] Package requires others for directories it uses but does not own [x] No duplication in %files unless necessary for license files [x] File permissions are sane [x] Package contains permissible code or content [x] Large docs go in -doc subpackage [x] %doc files not required at runtime [-] Static libs go in -static package/virtual Provides [-] Development files go in -devel package [-] -devel packages Require base with fully-versioned dependency, %_isa [-] No .la files [-] GUI app uses .desktop file, installs it with desktop-file-install [x] File list does not conflict with other packages' without justification [x] File names are valid UTF-8 Optional review guidelines: [x] Builds in mock [x] Functions as described (e.g. no crashes) [-] Scriptlets are sane [-] Subpackages require base with fully-versioned dependency if sensible [-] .pc file subpackage placement is sensible Naming guidelines: [x] Package names use only a-zA-Z0-9-._+ subject to restrictions on -._+ [x] Package names are sane [x] No naming conflicts [x] Spec file name matches base package name [x] Version is sane [x] Version does not contain ~ [x] Release is sane [x] %dist tag [x] Case used only when necessary [x] Renaming handled correctly Packaging guidelines: [x] Package obeys FHS, except libexecdir, /run, /usr/target [x] No files under /srv, /opt, /usr/local [x] Changelog in prescribed format [x] No Packager, Vendor, Copyright, PreReq tags [x] Summary does not end in a period [x] Correct BuildRoot tag on < EL6 [x] Correct %clean section on < EL6 [x] Requires correct, justified where necessary [x] Summary, description do not use trademarks incorrectly [x] All relevant documentation is packaged, appropriately marked with %doc [x] Doc files do not drag in extra dependencies (e.g. due to +x) [x] Spec uses macros consistently [x] Spec uses macros instead of hard-coded names where appropriate [x] Spec uses macros for executables only when configurability is needed [x] Build uses only python/perl/shell+coreutils/lua/BuildRequired langs [x] %global, not %define [x] File ops preserve timestamps [x] No Requires(pre,post) notation [x] One project per package [x] No bundled fonts [!] Available test suites executed in %check Python Specific: [x] Runtime Requires correct [x] Python macros declared on < EL6 [x] All .py files packaged with .pyc, .pyo counterparts [x] Includes .egg-info files/directories when generated [x] Provides/Requires properly filtered Comments: 1. Unit tests are not being run. This is okay because needed dependencies are not available. 2. Consider removing all the python3 code from the specfile if it is not going to be building with python3. This is not a blocker, but something to consider. Everything looks great! APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
