https://bugzilla.redhat.com/show_bug.cgi?id=842124
Rex Dieter <rdie...@math.unl.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #13 from Rex Dieter <rdie...@math.unl.edu> ---
OK, using
https://raw.github.com/chenxiaolong/Unity-for-Fedora/master/appmenu-qt/appmenu-qt.spec
as referenced...
1. MUST drop extraneous BuildRequires: gcc-c++
(see http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 )
naming: ok
sources: ok
md5sum *.bz2
90cce750e5412d43ce075b0a9bdb6782 appmenu-qt-0.2.6.tar.bz2
license: ok
macros: ok (but could use some polish, like using fedora's %_qt4_plugindir
macro instead of hard-coding %{_libdir}/qt4/plugins)
scriptlets: n/a
otherwise, it's a relatively simple package, I see nothing else that needs
work.
As far as I'm concerned, item 1 is relatively cosmetic, and it's ok with me as
long as it is addressed prior to doing any official fedora builds in koji.
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
