https://bugzilla.redhat.com/show_bug.cgi?id=810676
Pavel Zhukov <pa...@zhukoff.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(pa...@zhukoff.net |
|) |
--- Comment #21 from Pavel Zhukov <pa...@zhukoff.net> ---
(In reply to comment #19)
> the URL is invalid, it should be http://libre.adacore.com/tools/aws and not
> http://libre.adacore.com/libre/tools/AWS/
Fixed
(In reply to comment #20)
> (In reply to comment #15)
> > include/zlib removed.
>
> And I see that you also delete the bundled Templates Parser now. That leaves
> Memory Streams, Strings Cutter, Zlib-Ada and the SHA-1 implementation. We
> still need to decide what to do with those.
>
> The installed aws.gpr still mentions OpenSSL. And shouldn't it point to
> aws-net-std__ipv6.adb rather than aws-net-std__gnat.adb?
> Some other things I have noticed:
Yes, I didn't change aws.gpr. Fixed
> · The group of the base package should be System Environment/Libraries. AWS
> is a library, not a daemon. I think the -tools subpackage fits best in
> Development/Tools.
Fixed
> · template_parser.gpr should be deleted from aws-fedora.tgz.
Done
> · LDAP support seems to be missing. Is there a good reason for that?
I don't plan to use this feature (and test it). I'll add support in next
releases if anybody wants.
> · Please add comments explaining the patches. See
> <https://fedoraproject.org/wiki/Packaging:
> Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment>.
Done
To be continued...
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
