https://bugzilla.redhat.com/show_bug.cgi?id=845107
--- Comment #11 from Vít Ondruch <vondr...@redhat.com> ---
(In reply to comment #9)
> Vit - I've updated with your feedback.
Thank you.
* ruby_sitelib is not needed.
* You should not own %{gem_dir}
- The idea is to own %{gem_instdir}, i.e. %dir %{gem_instdir} and later own
everything contained in this directory explicitly, e.g. %{gem_libdir},
%doc %{gem_instdir}/LICENSE.
- This would unveil to you, that you are duplicating the LICENSE file in the
output package for example
* Keep the license and readme in original location
- i.e. you should replace %doc LICENSE with %doc %{gem_instdir}/LICENSE
(although there is currently discussion about this topic on packaging
list).
* Are selinux-policy-targeted and policycoreutils-python required?
- I did not dug into it too deeply, but are these really needed?
* Test suite
- What about the test suite? I expect that it will not be that easy, due to
nature of this package, but I'd like to know at least some feedback (it
would cover your back at the end)
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
