https://bugzilla.redhat.com/show_bug.cgi?id=848551
Mario Blättermann <mario.blaetterm...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Flags| |fedora-review?
--- Comment #7 from Mario Blättermann <mario.blaetterm...@gmail.com> ---
(In reply to comment #3)
> Requires: mobile-broadband-provider-info ModemManager gtk3
> Requires: dbus-python pygobject3 gtk3
>
> I'm surprised you call that "a lot".
> I removed the duplicate gtk3.
> Why is it a problem to list requirements explicity?
Usually there's almost nothing in "Requires" because most of the requirements
will be picked up automatically while building the package. Exceptions are
modules of Python, Perl and similar scripting languages and some other cases.
Packages which use Autotools don't need adding runtime requirements in most
cases, and according to the packaging guidelines you must not add them manually
if there's another way to pick them up.
(In reply to comment #4)
> I did that and ran a scratch build, and the requires list for that build is:
>
> $ rpm -qp --requires prepaid-manager-applet-0.0.3.1-2.fc17.noarch.rpm
> /bin/sh
> /bin/sh
> /bin/sh
> /bin/sh
> /usr/bin/python
> rpmlib(CompressedFileNames) <= 3.0.4-1
> rpmlib(FileDigests) <= 4.6.0-1
> rpmlib(PartialHardlinkSets) <= 4.0.4-1
> rpmlib(PayloadFilesHavePrefix) <= 4.0-1
> rpmlib(PayloadIsXz) <= 5.2-1
OK, in this case you can keep all the requirements excepting the duplicate of
gtk3.
I will do a formal review soon.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
