https://bugzilla.redhat.com/show_bug.cgi?id=833622
--- Comment #10 from Michael Cronenworth <m...@cchtml.com> --- (In reply to comment #9) > Please set the alias to the package name, as is customary for mingw > packages, then I'd have found your review request... This is news to me and I've been involved with MinGW on Fedora since it started. This alias will cause any future bug searches with quick search to find this bug instead of all bug reports. Using the alias this way is wrong. As soon as this review is over I will remove it. > $ rpmlint mingw-gmp.spec > mingw-gmp.spec:86: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: > line 86) Fixed. > > BR mingw32/64-gcc-c++ is missing > > What exactly are source2 and source3 used for? Some apps seem to assume that they are building against the gmp source tree and require the source versions of the gmp.h and gmp-mparam.h files. I wasn't installing those files so I have fixed that. > Your spec file seems to be derived from the native spec file - it would be > nice to acknowledge this eg. in the changelog. Most or all MinGW packages will base on the native spec file due to the simple fact that you are packaging the same software for a different environment. I don't see a need to add this line to every MinGW package. > > Can you elaborate on why you're unconfortable shipping -static subpackages? > It doesn't seem hard to do (see my spec file > http://sailer.fedorapeople.org/mingw-gmp.spec), and apparently some users > request it... I have no use for static libraries and almost all commercial Windows software ships DLLs instead of statically compiling. If the guy was reviewing my package I might consider adding a static package, but he was just kicking up dust. I don't have time for that. If you'd like to review my package I'd consider it. I realize there is a newer version of gmp available but for rawhide only. I'll ship 5.0.2 for F17 and the new version for F18+. New spec: http://michael.cronenworth.com/RPMS/mingw-gmp.spec New SRPM: http://michael.cronenworth.com/RPMS/mingw-gmp-5.0.2-2.fc17.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4423762 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
