https://bugzilla.redhat.com/show_bug.cgi?id=749608
--- Comment #10 from Mario Blättermann <mario.blaetterm...@gmail.com> --- (In reply to comment #9) > Build is failing on rawhide due to vala-devel, upstream still working on it. Doesn't matter, currently we should concentrate our effort to f18. BTW, building it for f17 is possible, see below. $ rpmlint -i -v * gnome-pie.src: I: checking gnome-pie.src: I: checking-url http://gnome-pie.simonschneegans.de/ (timeout 10 seconds) gnome-pie.src: W: invalid-url Source0: gnome-pie-0.5.3.20120826git1b93e1.tar.xz The value should be a valid, public HTTP, HTTPS, or FTP URL. gnome-pie.i686: I: checking gnome-pie.i686: I: checking-url http://gnome-pie.simonschneegans.de/ (timeout 10 seconds) gnome-pie.x86_64: I: checking gnome-pie.x86_64: I: checking-url http://gnome-pie.simonschneegans.de/ (timeout 10 seconds) gnome-pie-debuginfo.i686: I: checking gnome-pie-debuginfo.i686: I: checking-url http://gnome-pie.simonschneegans.de/ (timeout 10 seconds) gnome-pie-debuginfo.i686: E: debuginfo-without-sources This debuginfo package appears to contain debug symbols but no source files. This is often a sign of binaries being unexpectedly stripped too early during the build, or being compiled without compiler debug flags (which again often is a sign of distro's default compiler flags ignored which might have security consequences), or other compiler flags which result in rpmbuild's debuginfo extraction not working as expected. Verify that the binaries are not unexpectedly stripped and that the intended compiler flags are used. gnome-pie-debuginfo.x86_64: I: checking gnome-pie-debuginfo.x86_64: I: checking-url http://gnome-pie.simonschneegans.de/ (timeout 10 seconds) gnome-pie-debuginfo.x86_64: E: debuginfo-without-sources This debuginfo package appears to contain debug symbols but no source files. This is often a sign of binaries being unexpectedly stripped too early during the build, or being compiled without compiler debug flags (which again often is a sign of distro's default compiler flags ignored which might have security consequences), or other compiler flags which result in rpmbuild's debuginfo extraction not working as expected. Verify that the binaries are not unexpectedly stripped and that the intended compiler flags are used. gnome-pie.spec: W: invalid-url Source0: gnome-pie-0.5.3.20120826git1b93e1.tar.xz The value should be a valid, public HTTP, HTTPS, or FTP URL. 5 packages and 1 specfiles checked; 2 errors, 2 warnings. The invalid-source warning is not applicable, because it is a Git snapshot. But why don't you use the real download link: https://github.com/downloads/Simmesimme/Gnome-Pie/Gnome-Pie-0.5.3.tar.gz Should also work, or do we strictly need anything which has been committed after v0.5.3 has been released? According to README.md, the license is GPLv3+. The debug package is empty. Usually the following line in %build should help: make CFLAGS='%{optflags}' %{?_smp_mflags} This is valid for C code, but I'm unsure if this also works for Vala (which generates C code anyway). %{_mandir}/man1/%{name}.1.gz Please replace the gz extension by *, because the compression format for man pages could change in the future. The *.desktop file included in your package needs to be verified: http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage Moreover, add desktop-file-utils to BuildRequires. %{_datadir}/icons/* This would mean, your package owns all the subfolders of /usr/share/icons, which is not OK. Should be: %{_datadir}/icons/hicolor/scalable/apps/*.svg I ran a second scratch build for f17: http://koji.fedoraproject.org/koji/taskinfo?taskID=4423800 It was successful, so that I was able to test it. Because I use rather Xfce than Gnome, I was surprised that it works fine [1]. Just the compositing manager (compton on my system, instead of the builtin comp manager of xfwm4) doesn't collaborate well with gnome-pie. Doesn't matter, it was just for testing purposes. [1] http://www.flickr.com/photos/mariobl/7865891646/ -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
