https://bugzilla.redhat.com/show_bug.cgi?id=853050

Erik Schilling <ablu.erikschill...@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ablu.erikschilling@googlema
                   |                            |il.com

--- Comment #1 from Erik Schilling <ablu.erikschill...@googlemail.com> ---
Hi.

First: I am no "packager". This is an informal review:

Source0 should point to a location where the upstream tarball is located.
Also it looks like you took latest git status. There are tags inside of the git
repository that mark the releases. Checkout
https://github.com/fusesource/hawtbuf/tags.
You can also set the Source0 url to this location.

Making use of %{name} in the Source0 field cannot hurt either.

Best regards,
Erik

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to