https://bugzilla.redhat.com/show_bug.cgi?id=851734
--- Comment #3 from Petr Pisar <ppi...@redhat.com> --- Source tar ball is original (verified from <http://search.cpan.org/CPAN/authors/id/D/DC/DCONWAY/Regexp-Grammars-1.021.tar.gz>, SHA-256: d2f9bdbc7da37e787077f7abfdd4217db8b5e0a838a3f4ff8dfe423840b2417a). Ok. URL and Source0 are usable Ok. Summary verified from lib/Regexp/Grammars.pm. Ok. Description is Ok. License verified from lib/Regexp/Grammars.pm. Ok. No XS code exists, noarch BuildArch is Ok. TODO: Remove useless `perl(ExtUtils::MakeMaker)' build-require. Your spec file utilizes Module::Build build system. FIX: Build-require `perl(Scalar::Util)' for running tests (lib/Regexp/Grammars.pm:10). FIX: Build-require `perl(Data::Dumper)' for running tests (lib/Regexp/Grammars.pm:11). TODO: Build-require `perl(Moose)' for optional tests (t/moose.t:5). TODO: Build-require `perl(Moose::Util::TypeConstraints)' for optional tests (t/moose.t:13). FIX: Build-require `perl(List::Util)' for running tests (t/error_translate.t:5). FIX: %filter_from_requires /perl(List::Util)/ is not valid sed expression: Finding Requires: /bin/sh -c " while read FILE; do /usr/lib/rpm/rpmdeps -R ${FILE}; done | /bin/sort -u | /usr/bin/sed -e '/perl(List::Util)/'" /usr/bin/sed: -e expression #1, char 18: missing command I recommend to remove the macro and %filter_setup macro. There is no reason to remove non-existing run-time List::Util. All tests pass. Ok. $ rpmlint perl-Regexp-Grammars.spec ../SRPMS/perl-Regexp-Grammars-1.021-2.fc19.src.rpm ../RPMS/noarch/perl-Regexp-Grammars-1.021-2.fc19.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Regexp-Grammars-1.021-2.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Sep 12 16:54 /usr/share/doc/perl-Regexp-Grammars-1.021 -rw-r--r-- 1 root root 6299 Aug 20 05:55 /usr/share/doc/perl-Regexp-Grammars-1.021/Changes -rw-r--r-- 1 root root 633 Aug 20 05:55 /usr/share/doc/perl-Regexp-Grammars-1.021/README drwxr-xr-x 2 root root 0 Sep 12 16:54 /usr/share/doc/perl-Regexp-Grammars-1.021/demo -rw-r--r-- 1 root root 394 Nov 2 2011 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_IP4.pl -rw-r--r-- 1 root root 3947 Nov 2 2011 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_LaTeXish.pl -rw-r--r-- 1 root root 1871 Nov 2 2011 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_LaTeXish_dump.pl -rw-r--r-- 1 root root 1234 Nov 2 2011 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_Lucene_query.pl -rw-r--r-- 1 root root 705 Aug 30 2011 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_calc.pl -rw-r--r-- 1 root root 1633 Apr 20 2010 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_calc_class.pl -rw-r--r-- 1 root root 1207 Nov 2 2011 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_calc_inline.pl -rw-r--r-- 1 root root 644 Nov 2 2011 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_calc_list.pl -rw-r--r-- 1 root root 1272 Nov 2 2011 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_calc_list_autoactions.pl -rw-r--r-- 1 root root 1278 Nov 2 2011 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_calc_list_inline.pl -rw-r--r-- 1 root root 457 May 2 2011 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_debug.pl -rw-r--r-- 1 root root 1673 Nov 2 2011 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_error.pl -rw-r--r-- 1 root root 1755 Nov 2 2011 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_error_non_backtracking.pl -rw-r--r-- 1 root root 1086 Aug 24 2009 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_flattening.pl -rw-r--r-- 1 root root 457 Mar 2 2010 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_hash.pl -rw-r--r-- 1 root root 519591 Nov 26 2009 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_hash_lexicon.pl -rw-r--r-- 1 root root 1662 Oct 26 2011 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_hash_lookup_generated.pl -rw-r--r-- 1 root root 1783 Oct 26 2011 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_hash_lookup_hardcoded.pl -rw-r--r-- 1 root root 1538 Oct 26 2011 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_hash_lookup_hashrule.pl -rw-r--r-- 1 root root 868 Mar 2 2010 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_hash_symtab.pl -rw-r--r-- 1 root root 1348 Apr 5 2011 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_hashlines.pl -rw-r--r-- 1 root root 531 Nov 2 2011 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_list.pl -rw-r--r-- 1 root root 2326 Nov 2 2011 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_metagrammar.pl -rw-r--r-- 1 root root 528 Aug 9 00:41 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_pos.pl -rw-r--r-- 1 root root 371 Oct 26 2011 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_raw_debug.pl -rw-r--r-- 1 root root 284 Aug 2 2009 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_require.pl -rw-r--r-- 1 root root 2814 Nov 2 2011 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_rfc5322.pl -rw-r--r-- 1 root root 4011 Aug 2 2009 /usr/share/doc/perl-Regexp-Grammars-1.021/demo/demo_whoson.pl -rw-r--r-- 1 root root 45261 Sep 12 16:54 /usr/share/man/man3/Regexp::Grammars.3pm.gz drwxr-xr-x 2 root root 0 Sep 12 16:54 /usr/share/perl5/vendor_perl/Regexp -rw-r--r-- 1 root root 224950 Sep 12 16:54 /usr/share/perl5/vendor_perl/Regexp/Grammars.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Regexp-Grammars-1.021-2.fc19.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.16.1) 1 perl(Scalar::Util) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Run-require `perl(Data::Dumper)' (lib/Regexp/Grammars.pm:11). $ rpm -q --provides -p ../RPMS/noarch/perl-Regexp-Grammars-1.021-2.fc19.noarch.rpm | sort | uniq -c 1 perl(Calculator_Actions) 1 perl(Regexp) 1 perl(Regexp::Grammars) = 1.021 1 perl-Regexp-Grammars = 1.021-2.fc19 1 perl(Regexp::Grammars::Precursor) FIX: Do not provide `perl(Calculator_Actions)' from demo in documentation. Fix: Do not provide private `perl(Regexp)' (this would clash with `Regexp' CPAN module). Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4477993). Ok. Please correct all `FIX' items, consider correcting `TODO' issues and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
