https://bugzilla.redhat.com/show_bug.cgi?id=858060
--- Comment #4 from Darryl L. Pierce <dpie...@redhat.com> --- (In reply to comment #3) > SPEC URL: http://eallen.fedorapeople.org/qpid-snmpd.spec > SRPM URL: http://eallen.fedorapeople.org/qpid-snmpd-1.0.0-3.fc17.src.rpm > TAR URL: http://eallen.fedorapeople.org/qpid-snmpd-1.0.0.tar.bz2 > > Reverted to original tar.bz2 to avoid re-running review tests. > > Spec file was updated to remove the %{source-dir} global. Now uses pushd and > pop with the original tar.bz2 source directory name. For future packages, > I'll just place the source in the root of the tar.bz2 to avoid these > problems. No need to do that. You should keep the directory name within the tarball as %{name}-%{version}, then use %setup -q -c %{name}-%{version} pushd %{name}-%{version} That way you can always know in your source tarball which version of the code it represents, should the filename somehow get munged. > The "[!] not met" sections have been addressed. The rpmlint warnings aren't show stoppers, so you can fix them after this review. The main complaint (the "incoherent-subsys" message) is due to the /etc/rc.d/init.d/qpid-snmpd script using "$name" rather than explicitly stating the name of the service. Since the script's not re-used, just replace "$name" with "qpid-snmpd" and that error will go away. The other complaint ("service-default-enabled") is because the installation enables the service by default. That's not really supposed to be done: the service should be added, but the administrator should be the one to set it to on explicitly. Those two things should be fixed before pushing out the first build. The issue with the %doc files is fixed. The issue with permissions on a few of the installed files is fixed. All in all, this looks good. With the above caveats about the rpmlint errors, I'll go ahead and approve this package. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
