https://bugzilla.redhat.com/show_bug.cgi?id=846488
Volker Fröhlich <volke...@gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |volke...@gmx.at
--- Comment #3 from Volker Fröhlich <volke...@gmx.at> ---
Shared lib calls exit. This should be reported upstream.
Please make the build verbose.
You can use the name macro once more in Source0, if you want.
I'm not sure about the license. I wonder why include/babeltrace/list.h claims
LGPLv2. That one test is GPLv2, which I find a little strange. Should that
really make it GPL instead of LGPL?
Only include the license files in the libs-subpackage.
The descriptions should reflect the content of the actual packages.
The clean section is obsolete.
Can you use make %{?_smp_mflags}?
The main package needs no ldconfig.
Change *.1.gz to *.1*
Requires must contain the isa macro:
http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
Your main package should require the lib sub-package.
Can you run the tests?
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
