Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=545720 Christoph Wickert <cwick...@fedoraproject.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cwick...@fedoraproject.org --- Comment #25 from Christoph Wickert <cwick...@fedoraproject.org> 2010-04-11 20:01:10 EDT --- @Mario: Some things got overlooked during this review, please read my comments below. No need to worry, this is why we have sponsors and public mailing lists for the commits. @Leon: Please don't use macros for trivial things like %{__rm} or %{__python}. This was discussed on devel list recently, please read the thread that evolted after this mail: http://lists.fedoraproject.org/pipermail/devel/2010-March/133466.html %{__python} setup.py install --root %{buildroot} should normally be %{__python} setup.py install -O1 --skip-build --root %{buildroot} if you take a look at the buildlog, you will see that the build step is run twice The locales are not built built but the precompiled mo files are taken. You will need to build them which required gettext and intltool. %{_datadir}/applications/googsystray-settings.desktop %{_datadir}/applications/googsystray.desktop These files should have been installed desktop-file-install or at least be validated with desktop-file-validate. see https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files %{_datadir}/icons/googsystray.png This file should go into %{_datadir}/pixmaps/ %{_datadir}/icons/hicolor/16x16/apps/googsystray.png %{_datadir}/icons/hicolor/32x32/apps/googsystray.png %{_datadir}/icons/hicolor/48x48/apps/googsystray.png %{_datadir}/icons/hicolor/64x64/apps/googsystray.png You should use wildcards here: %{_datadir}/icons/hicolor/*/apps/googsystray.png -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
