https://bugzilla.redhat.com/show_bug.cgi?id=860518
--- Comment #10 from Rex Dieter <rdie...@math.unl.edu> ---
naming: ok
sources: ok
98c7cf97e806edb72bbdfc1d975bcd7e mate-panel-1.4.0.tar.xz
license: ok , please add comment that libraries are LGPLv2+, applications
GPLv2+
macros: ok
builds: ok
1. scriptlets: not ok.
MUST remove /sbin/ldconfig scriptlet from %pre, add to %postun
MUST put gtk-update-icon-cache in %posttrans
2. SHOULD move
%{_datadir}/gtk-doc/html/mate-panel-applet/
to -devel pkg
3. SHOULD simplify %files for icons to just
%{_datadir}/icons/hicolor/*/*/*
as-is, you're owning some dirs in there
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
