https://bugzilla.redhat.com/show_bug.cgi?id=864941

Mario Blättermann <mario.blaetterm...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mario.blaetterm...@gmail.co
                   |                            |m
           Assignee|nob...@fedoraproject.org    |mario.blaetterm...@gmail.co
                   |                            |m
              Flags|                            |fedora-review?

--- Comment #1 from Mario Blättermann <mario.blaetterm...@gmail.com> ---
Taking this for review. Be patient, could need some days.

I had a first look at the spec. Some issues:

%{_mandir}/man1/%{name}.1.gz

Currently our man pages are gzipped, but this could change in the future.
Please use

%{_mandir}/man1/%{name}.1.*

and remove the trailing whitespace.



To make sure that subsurface picks up the right version of libdivecomputer in
any case, you could use a %global definition:

%global libdivecomputerversion 0.2.0
...
BuildRequires:  libdivecomputer-devel == %{libdivecomputerversion}
BuildRequires:  libdivecomputer-static == %{libdivecomputerversion}
...
Requires:       libdivecomputer == %{libdivecomputerversion}


glib2-devel is a recursive dependency of gtk2-devel, you might drop it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to