https://bugzilla.redhat.com/show_bug.cgi?id=865630

Eduardo Echeverria <echevemas...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nob...@fedoraproject.org    |echevemas...@gmail.com
              Flags|                            |fedora-review?

--- Comment #7 from Eduardo Echeverria <echevemas...@gmail.com> ---
Thanks a lot Peter 

Hi Saveliev 
Welcome to the group package maintainers

some comments:
- It is good practice to use macros to preserve the name of the application
You can just do this:
%global pkgname pyvfs
Name:        Name: python-pyvfs
Source0: http://peet.spb.ru/archives/%{pkgname}-%version.tar.gz
%prep
%setup -q -n %{pkgname}-%{version}

- Remember to increase the release number each time you make a change in spec
and Changelog
https://fedoraproject.org/wiki/Packaging:NamingGuidelines?rd=Packaging/NamingGuidelines#Release_Tag
Example: 

Release:       2%{?dist}
%changelog
* Thu Oct 13 2012 Peter V. Saveliev <p...@redhat.com> 0.2.3-1
- Add build section
- Change BuildRequires python2-devel
- Change to correct group 
- Include doc section 

Release:       1%{?dist}
%changelog
* Thu Oct 11 2012 Peter V. Saveliev <p...@redhat.com> 0.2.3-1
- initial RH build

- MD5-sum check differs
-------------
http://peet.spb.ru/archives/pyvfs-0.2.3.tar.gz :
  CHECKSUM(SHA256) this package     :
fa629cf0d5c72cf0475d330d64260103c167ac126$
  CHECKSUM(SHA256) upstream package :
18801e743f3d3c30ebe444c29dc2ed77ff926d3d3$

Please use wget -N for downloading the sources

Please fix this issues and I do the formal review

Best Regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to