https://bugzilla.redhat.com/show_bug.cgi?id=829097
--- Comment #2 from Rich Mattes <richmat...@gmail.com> --- I just submitted the patch upstream, and included a comment in the spec (In reply to comment #1) > Did you try to submit your patch? > I hadn't, but I just did today. The link to the upstream tracker is now in the spec, as is a description of what the patch does > Don't the other methods work that are described in > http://fedoraproject.org/wiki/Packaging:Guidelines#Removing_Rpath ? > It looks like the second method concerning a local copy of libtool works. I got rid of chrpath and am instead using the sed snippets from the wiki. > rm -rf %{buildroot} is not necessary. > Removed. > It must be: > > %post -p /sbin/ldconfig > %postun -p /sbin/ldconfig > Fixed. > I noticed the PDFs make up most of the size of the package. Consider a > separated -doc sub-package, as mentioned here: > http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation > They're a total of a little over a meg, which isn't too huge. They're not purely development docs either as some has to do with wiring the lasers and with running the example programs. I split off a doc subpackage > THANKS, NEWS and the examples directory could also be included. > Included. > I'd like to recommend registering the libray on http://upstream-tracker.org > to keep track of ABI breakage. > That's definitely a useful site, but the sicktoolbox isn't really actively developed anymore. The last svn commits are from 2 years ago. > You can remove the trailing slash from the URL, if you want. > > Odd findings: "ld_config" sounds a lot like ldconfig. The version numbers > that is part of the include-directories also surprised me. I guess they were following the lms_config example. The toolbox supports both the LMS and LD lines of laser rangefinders, so i guess it's just an unfortunate coincidence. If it's a problem, I can rename the executables to sick_lms_config and sick_ld_config. The version number in the includedirs is strange, and the versions in the library names are kind of annoying, but I don't know if it's annoying enough to break compatibility with upstream. New spec and SRPM can be found at: Spec URL: http://rmattes.fedorapeople.org/RPMS/sicktoolbox/sicktoolbox.spec SRPM URL: http://rmattes.fedorapeople.org/RPMS/sicktoolbox/sicktoolbox-1.0.1-2.fc17.src.rpm rpmlint: $ rpmlint sicktoolbox.spec ../RPMS/x86_64/sicktoolbox-* ../RPMS/noarch/sicktoolbox-* sicktoolbox.x86_64: W: no-manual-page-for-binary ld_config sicktoolbox.x86_64: W: no-manual-page-for-binary lms_config sicktoolbox-devel.x86_64: W: no-documentation 4 packages and 1 specfiles checked; 0 errors, 3 warnings. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
