https://bugzilla.redhat.com/show_bug.cgi?id=840109
--- Comment #1 from Remi Collet <fed...@famillecollet.com> ---
Could you update to latest version 0.3.8 before I do a formal review ?
Some notes
- you don't have to compress the generated man page (will be done by rpmbuild,
and compression tool could change, one day)
- tests are currently installed in /usr/share/php, which is in the default
include_path. There is no Guidelines about this, but I think it's a bad
practice.
Please consider moving to /usr/share/tests/php-lessphp
(you need to own /usr/share/tests or requires pear which own this dir)
- sed (to add shebang) is a bit hard to read.
Isn't simpler to use :
sed -e '1i#!/bin/bash\n' -i %{libname}/tests/bootstrap.sh
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
